Files
FFmpeg/libavformat
Ico Doornekamp 7f3a3c2010 avformat/rtpdec_jpeg: fix low contrast image on low quality setting
Original mail and my own followup on ffmpeg-user earlier today:

I have a device sending out a MJPEG/RTP stream on a low quality setting.
Decoding and displaying the video with libavformat results in a washed
out, low contrast, greyish image. Playing the same stream with VLC results
in proper color representation.

Screenshots for comparison:

  http://zevv.nl/div/libav/shot-ffplay.jpg
  http://zevv.nl/div/libav/shot-vlc.jpg

A pcap capture of a few seconds of video and SDP file for playing the
stream are available at

  http://zevv.nl/div/libav/mjpeg.pcap
  http://zevv.nl/div/libav/mjpeg.sdp

I believe the problem might be in the calculation of the quantization
tables in the function create_default_qtables(), the attached patch
solves the issue for me.

The problem is that the argument 'q' is of the type uint8_t. According to the
JPEG standard, if 1 <= q <= 50, the scale factor 'S' should be 5000 / Q.
Because the create_default_qtables() reuses the variable 'q' to store the
result of this calculation, for small values of q < 19, q wil subsequently
overflow and give wrong results in the calculated quantization tables. The
patch below uses a new variable 'S' (same name as in RFC2435) with the proper
range to store the result of the division.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit e3e6a2cff4)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
2017-08-23 13:15:16 +02:00
..
2014-08-24 11:05:42 +00:00
2013-12-25 17:14:32 +01:00
2016-01-31 00:25:20 +01:00
2014-09-13 23:02:51 +02:00
2016-02-01 02:12:22 +01:00
2014-08-09 15:51:04 +02:00
2016-01-28 02:15:49 +01:00
2014-08-30 15:50:22 +00:00
2014-08-24 11:05:42 +00:00
2014-06-18 14:55:28 +02:00
2014-06-18 14:55:28 +02:00
2014-08-24 11:05:42 +00:00
2016-01-31 00:25:20 +01:00
2014-04-16 19:41:41 +02:00
2014-08-24 11:05:42 +00:00
2014-04-01 01:13:09 +02:00
2015-10-09 22:07:29 +02:00
2014-04-05 02:18:09 +02:00
2013-12-23 16:28:44 +01:00
2014-07-03 15:46:26 +02:00
2015-01-18 02:38:01 +01:00
2014-07-13 19:18:31 +02:00
2014-07-13 19:18:31 +02:00
2014-08-15 22:47:45 +02:00
2014-09-03 02:39:24 +02:00
2014-11-14 20:22:40 +01:00
2015-01-13 00:04:43 +01:00
2014-05-17 20:13:33 +02:00
2015-06-01 23:25:19 +02:00
2015-12-20 16:14:07 +01:00
2014-08-30 16:38:14 +02:00
2014-04-20 20:56:02 +02:00
2014-08-24 11:05:42 +00:00
2014-09-02 12:02:03 +02:00
2015-11-26 01:38:17 +01:00
2013-12-25 17:38:29 +01:00
2014-12-19 18:02:13 -03:00
2014-09-03 02:39:24 +02:00
2014-08-15 22:47:45 +02:00
2014-09-03 02:39:24 +02:00
2014-03-04 22:54:13 +01:00
2014-09-05 23:13:07 +02:00
2014-10-04 23:52:29 +02:00
2014-07-19 19:44:56 +02:00
2014-08-24 11:05:42 +00:00
2014-08-24 11:05:42 +00:00
2014-09-05 23:13:08 +02:00
2014-03-08 12:36:57 +01:00
2014-08-03 03:18:52 +02:00
2014-08-24 11:05:42 +00:00
2014-08-24 11:05:42 +00:00
2014-08-24 11:05:42 +00:00