github-mirrors/oh-my-claudecode
1
0
Fork 0
mirror of https://fastgit.cc/github.com/Yeachan-Heo/oh-my-claudecode synced 2026-04-20 12:51:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2719 from Yeachan-Heo/fix/issue-2715-hud-npm-cmd-einval

Browse Source 
Fix Windows HUD npm.cmd EINVAL fallback
This commit is contained in:
Bellman
2026-04-18 18:29:39 +09:00
committed by GitHub
parent dba5633f91 56513f28a2
commit 05b7c04115
7 changed files with 40 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
dist/__tests__/hud-windows.test.js generated vendored
View File

@@ -53,6 +53,14 @@ describe('HUD Windows Compatibility', () => {
const content = readFileSync(templatePath, 'utf-8');
expect(content).toContain('pathToFileURL(pluginPath).href');
});
it('shared HUD wrapper template uses shell:true only for Windows npm root discovery', () => {
const templatePath = join(packageRoot, 'scripts', 'lib', 'hud-wrapper-template.txt');
const content = readFileSync(templatePath, 'utf-8');
expect(content).toContain('const isWin = process.platform === "win32";');
expect(content).toContain('const npmCommand = isWin ? "npm.cmd" : "npm";');
expect(content).toContain('shell: isWin');
expect(content).not.toContain('shell: true');
});
it('pathToFileURL should correctly convert Unix paths', () => {
const unixPath = '/home/user/test.js';
expect(pathToFileURL(unixPath).href).toBe(process.platform === 'win32'

2
dist/__tests__/hud-windows.test.js.map generated vendored
View File

File diff suppressed because one or more lines are too long

7
dist/installer/__tests__/hud-wrapper-env.test.js generated vendored
View File

@@ -229,6 +229,13 @@ describe('HUD wrapper — OMC_PLUGIN_ROOT resolution', () => {
expect(txt).not.toContain('Workspace/oh-my-claudecode');
expect(txt).not.toContain('projects/oh-my-claudecode');
});
it('uses shell:true only for Windows npm root discovery', () => {
const txt = readFileSync(TEMPLATE_TXT, 'utf8');
expect(txt).toContain('const isWin = process.platform === "win32";');
expect(txt).toContain('const npmCommand = isWin ? "npm.cmd" : "npm";');
expect(txt).toContain('shell: isWin');
expect(txt).not.toContain('shell: true');
});
});
describe('HUD wrapper — fixture sanity', () => {
it('the template txt file exists in the repo', () => {

2
dist/installer/__tests__/hud-wrapper-env.test.js.map generated vendored
View File

File diff suppressed because one or more lines are too long

6
scripts/lib/hud-wrapper-template.txt
View File

@@ -46,11 +46,15 @@ function getGlobalNodeModuleRoots() {
}
try {
const npmCommand = process.platform === "win32" ? "npm.cmd" : "npm";
const isWin = process.platform === "win32";
const npmCommand = isWin ? "npm.cmd" : "npm";
const npmRoot = String(execFileSync(npmCommand, ["root", "-g"], {
encoding: "utf8",
stdio: ["ignore", "pipe", "ignore"],
timeout: 1500,
// Node 20.12+ rejects direct .cmd/.bat spawns without a shell on Windows.
// Keep non-Windows behavior unchanged by only enabling shell there.
shell: isWin,
})).trim();
if (npmRoot) roots.unshift(npmRoot);
} catch { /* continue */ }

9
src/__tests__/hud-windows.test.ts
View File

@@ -63,6 +63,15 @@ describe('HUD Windows Compatibility', () => {
expect(content).toContain('pathToFileURL(pluginPath).href');
});
it('shared HUD wrapper template uses shell:true only for Windows npm root discovery', () => {
const templatePath = join(packageRoot, 'scripts', 'lib', 'hud-wrapper-template.txt');
const content = readFileSync(templatePath, 'utf-8');
expect(content).toContain('const isWin = process.platform === "win32";');
expect(content).toContain('const npmCommand = isWin ? "npm.cmd" : "npm";');
expect(content).toContain('shell: isWin');
expect(content).not.toContain('shell: true');
});
it('pathToFileURL should correctly convert Unix paths', () => {
const unixPath = '/home/user/test.js';
expect(pathToFileURL(unixPath).href).toBe(

9
src/installer/__tests__/hud-wrapper-env.test.ts
View File

@@ -302,6 +302,15 @@ describe('HUD wrapper — OMC_PLUGIN_ROOT resolution', () => {
expect(txt).not.toContain('Workspace/oh-my-claudecode');
expect(txt).not.toContain('projects/oh-my-claudecode');
});
it('uses shell:true only for Windows npm root discovery', () => {
const txt = readFileSync(TEMPLATE_TXT, 'utf8');
expect(txt).toContain('const isWin = process.platform === "win32";');
expect(txt).toContain('const npmCommand = isWin ? "npm.cmd" : "npm";');
expect(txt).toContain('shell: isWin');
expect(txt).not.toContain('shell: true');
});
});
describe('HUD wrapper — fixture sanity', () => {