7 Commits

Author SHA1 Message Date
Bellman
1ecaf2e9b7 fix: remove dead code from deprecated features (#1659)
* fix: remove dead code from deprecated features (ultrapilot, codex/gemini MCP, swarm)

Remove ~2,500 lines of verified dead code across 6 cleanup waves:

- Delete dead ultrapilot hook module (1,484 lines, zero callers)
- Delete deprecated codex/gemini MCP wrappers, scripts, and tests
- Migrate job-state-db imports from deprecated mcp/ wrapper to lib/
- Remove dead DEPRECATED_MODES constant from constants/names.ts
- Remove deprecated shouldUseNodeHooks() and getHookScripts() from installer
- Remove deprecated CLI init command (replaced by /omc-setup)
- Remove dead code in comment-checker (unused function + variable)
- Clean ultrapilot/swarm references from 12 doc files

Evidence-based: every deletion verified via import graph analysis
through 3-iteration RALPLAN consensus (Planner→Architect→Critic).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: remove tests for deleted ask-codex/ask-gemini wrapper scripts

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 18:29:19 +09:00
Bellman
8641e541c6 refactor(agents): consolidate 4 overlapping agent pairs (22→18 agents) (#1426)
* refactor(skills): eliminate 5 thin wrapper skills + CLAUDE.md diet

Part 1: Delete 5 thin wrapper skills that duplicated agent prompts:
- analyze -> debugger/architect (merged unique content)
- build-fix -> build-fixer (no unique content)
- tdd -> test-engineer (merged TDD enforcement)
- code-review -> code-reviewer (merged review checklist)
- security-review -> security-reviewer (merged OWASP/checklists)

Keyword routing preserved: tdd/analyze keywords now route through
bridge.ts message constants (TDD_MESSAGE, ANALYZE_MESSAGE) instead
of skill invocations in keyword-detector.mjs.

Part 2: Trim docs/CLAUDE.md from 177 to 83 lines (53% reduction).
Agent catalog compressed to bare name+model list. Skills section
compacted. All section headers preserved.

Updated: tests, REFERENCE.md (en/ko), MIGRATION.md (en/ko),
skills/AGENTS.md, skill-state protection map, keyword-detector
priority array.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* refactor(agents): consolidate 4 overlapping agent pairs (22→18 agents)

Merge 4 agent pairs using always-thorough strategy (no flags, no modes):
- code-reviewer absorbs quality-reviewer (adds style, performance, quality strategy modes)
- critic absorbs harsh-critic (adds 5-phase investigation, adaptive harshness, gap analysis)
- debugger absorbs build-fixer (adds build/compile error handling, lsp_diagnostics_directory)
- executor absorbs deep-executor (adds task classification, explore-first protocol, circuit breaker)

Registry changes:
- Remove quality-reviewer, deep-executor, build-fixer from agent registry
- Remove harsh-critic conditional registration (enableHarshCritic feature toggle deleted)
- Agent count: 22→18 (deterministic, no conditional agents)

Backward compatibility:
- DEPRECATED_ROLE_ALIASES in delegation routing for all 4 absorbed agents
- HUD badge fallbacks map old names to survivor abbreviations

Updates across: delegation routing, permission handler, autopilot prompts,
HUD elements, team skill, docs, tests, and config schema.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* chore(review): sync generated artifacts for agent consolidation

* fix(review): restore compatibility contracts after agent consolidation

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 12:00:54 +09:00
Yeachan-Heo
a2b1c364ea feat: deprecate ecomode and tighten magic keyword detection
Remove ecomode entirely from the codebase including skill, CLI commands,
config options, model routing integration, state management, and all
references in docs/tests/templates.

Tighten keyword detector patterns to reduce false positives:
- autopilot: remove broad phrase patterns (build me, create me, etc.)
- ralph: keep only exact "ralph" match
- ultrawork: keep only "ultrawork" and "ulw"
- ultrathink: keep only "ultrathink" (remove "think hard/deeply")
- deepsearch: keep "deepsearch", "search the codebase", "find in codebase"
- analyze: keep only "deep analyze/deepanalyze/deep-analyze"
- pipeline: keep only "agent pipeline" and "chain agents"
- tdd: keep only "tdd" and "test first" (remove "red green")

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-15 16:56:17 +00:00
Yeachan-Heo
d9471c6e73 refactor: rename research skill to sciomc and researcher agent to document-specialist
- Rename `skills/research/` -> `skills/sciomc/` to avoid false-positive magic keyword detection
- Rename `agents/researcher.md` -> `agents/document-specialist.md` with updated prompts
- Rename `src/agents/researcher.ts` -> `src/agents/document-specialist.ts`
- Remove "research" from keyword detector (src + runtime template)
- Create new `skills/external-context/` skill for parallel document-specialist web searches
- Update all cross-references across agents, routing, HUD, CLI, hooks, docs, and tests
- Maintain backward compatibility aliases (researcher -> document-specialist)
- Keep `.omc/research/` output paths unchanged

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-14 08:27:30 +00:00
Bellman
5eb8d5e1c6 docs: increase parallel agent limit from 5 to 20 across all modes (#548)
Team mode has proven effective with higher agent counts. Update all
documentation, skill definitions, and source defaults to allow up to
20 concurrent agents instead of the previous 5-agent limit.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-11 11:05:33 +09:00
Bellman
61bdeea636 fix: notepad.md session short-term memory (#342)
* fix: address Copilot review issues and additional bug fixes

Copilot Review Fixes (PR #328):
- normalizePath(): Use path.resolve() + path.normalize() for proper handling
  of path separators, relative segments, and trailing slashes
- isStateForCurrentProject(): Require project_path for global state files
  to prevent cross-project state leakage (local files accept legacy states)
- Ralph linked ultrawork: Include session_id and project_path for proper
  project isolation

Bug Fixes (#325):
- State manager: Add atomic write using temp file + rename pattern
- Notepad: Add atomic writes to prevent race conditions
- Swarm: Add try-catch around better-sqlite3 dynamic import
- HUD todos: Fix null crash when activeForm and content are both undefined
- Installer: Change MIN_NODE_VERSION from 18 to 20 to match package.json
- HUD: Distinguish installation errors from runtime errors

Tests:
- Add project isolation tests for project_path validation
- Update top-agents.test.ts to be quote-style agnostic

* fix: address Copilot round-2 review - use shared atomic write module

- Add atomicWriteFileSync and atomicWriteJsonSync to src/lib/atomic-write.ts
  with proper fsync, exclusive creation (wx flag), and directory sync
- Update state-manager/index.ts to use shared atomicWriteJsonSync
- Update notepad/index.ts to use shared atomicWriteFileSync
- Fix swarm/state.ts: log importError instead of ignoring
- Fix swarm/state.ts: use atomicWriteJsonSync in writeSwarmSummary()
- Fix hud/index.ts: add stdout fallback message on runtime errors

* chore: release v3.9.9 - version bump

* chore: bump .claude-plugin version to 3.9.9

* fix: notepad.md session short-term memory not working (#342)

- Add notepad Priority Context injection to session-start hook so it is
  always loaded on session start as documented
- Replace plain writeFileSync with atomic writes in post-tool-use hook
  to prevent data corruption from race conditions
- Add shared atomic-write.mjs library for hook modules
- Fix integration test import path (sisyphus-orchestrator → omc-orchestrator)
- Document notepad system in docs/CLAUDE.md and features reference

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Test User <test@example.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-03 22:53:13 +00:00
Yeachan-Heo
bdeb2d6723 fix: resolve 12 issues from PR #254 review
CRITICAL fixes:
- C1: Restore MCP Agent Tool Matrix in docs/shared/agent-tiers.md
- C2: Preserve Part 4 content in docs/shared/features.md
- C3: Fix false-positive regex patterns in tier-selector.ts
- C4: Remove index.(ts|js) from architectural pattern detection
- C5: Change skill doc links to explicit read instructions

HIGH fixes:
- H1: Add state file paths to mode-hierarchy.md
- H2: Add completion verification section to ultrawork skill
- H3: Set STANDARD minimum verification tier for ralph
- H4: Add workflow diagram to architect.md
- H5: Restore delegation enforcement rules in ecomode skill
- H6: Add boundary value and false-positive tests for tier-selector
- H7: Add plan rejection handoff row to critic.md

Tests: 1892 passed, TypeScript clean

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 06:41:17 +00:00