mirror of https://fastgit.cc/github.com/Yeachan-Heo/oh-my-claudecode synced 2026-04-21 05:12:30 +08:00

Files

Codex Review f6b3ff2bda Close the remaining PR #2694 documentation acceptance blockers

The original company-context interface change landed with the right code and
skill-surface updates, but review correctly held the PR until the missing
acceptance-doc pieces were explicit. This follow-up adds the settings-schema
page entry for companyContext and records the issue's requested ~5% prompt-
directive miss-rate / residual-risk language without widening runtime scope.

Constraint: Keep the follow-up documentation-only and avoid runtime behavior changes
Constraint: Satisfy issue #2692 acceptance criteria exactly enough for merge review
Rejected: Expand the fix into broader doc cross-linking or runtime wording cleanup | unnecessary scope growth for a blocked PR follow-up
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: Keep future company-context changes aligned with the current .claude/omc.jsonc / ~/.config/claude-omc/config.jsonc config surface unless the runtime contract changes first
Tested: npx vitest run src/config/__tests__/loader.test.ts -t "company context configuration"
Tested: git diff --check -- docs/company-context-interface.md docs/settings-schema.md
Tested: local link existence check for docs/settings-schema.md -> ./company-context-interface.md
Tested: lsp_diagnostics on both changed docs files reported 0 errors
Tested: architect verification APPROVED
Not-tested: Full repo build/test suite (intentionally skipped for docs-only narrow follow-up)

2026-04-17 14:24:21 +00:00

1.5 KiB

Raw Permalink Blame History

Settings Schema

This page documents OMC-owned configuration keys in the standard OMC config files:

Project: .claude/omc.jsonc
User: ~/.config/claude-omc/config.jsonc

Project config overrides user config.

`omc.companyContext` / `companyContext`

Issue #2692 and the PR #2694 follow-up review refer to this setting as omc.companyContext. In the current OMC config surface, the same block is written as the top-level companyContext object inside the OMC config files above.

{
  "companyContext": {
    "tool": "mcp__vendor__get_company_context",
    "onError": "warn"
  }
}

Fields

Field	Type	Required	Default	Meaning
`tool`	`string`	No	none	Full MCP tool name to call, for example `mcp__vendor__get_company_context`
`onError`	`"warn" \| "silent" \| "fail"`	No	`"warn"`	How prompt workflows react when the configured company-context tool call fails

Behavior

If companyContext is omitted, the feature is off and workflows continue normally.
If tool is configured, supported workflow prompts may call that MCP tool at their documented stage.
onError: "warn" notes the failure and continues.
onError: "silent" continues without an extra note.
onError: "fail" stops and surfaces the tool-call error.

This remains a prompt-level workflow contract, not runtime enforcement. For the full interface, trust boundary, trigger stages, and residual risk, see company-context-interface.md.

1.5 KiB Raw Permalink Blame History

Settings Schema

omc.companyContext / companyContext

Fields

Behavior

1.5 KiB

Raw Permalink Blame History

`omc.companyContext` / `companyContext`