From b997a29e24d97d92bb3e57f4842184cff4e4b8fc Mon Sep 17 00:00:00 2001 From: Jeon Insoo Date: Sun, 5 Apr 2026 20:35:15 +0900 Subject: [PATCH] tracing: fix startup failure for insecure OTLP HTTP tracing Signed-off-by: Jeon Insoo --- tracing/tracing.go | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tracing/tracing.go b/tracing/tracing.go index 65418d1214..932fab92b6 100644 --- a/tracing/tracing.go +++ b/tracing/tracing.go @@ -207,6 +207,14 @@ func getClient(tracingCfg config.TracingConfig) (otlptrace.Client, error) { opts := []otlptracehttp.Option{otlptracehttp.WithEndpoint(tracingCfg.Endpoint)} if tracingCfg.Insecure { opts = append(opts, otlptracehttp.WithInsecure()) + } else { + // Use of TLS Credentials forces the use of TLS. Therefore it can + // only be set when `insecure` is set to false. + tlsConf, err := config_util.NewTLSConfig(&tracingCfg.TLSConfig) + if err != nil { + return nil, err + } + opts = append(opts, otlptracehttp.WithTLSClientConfig(tlsConf)) } // Currently, OTEL supports only gzip compression. if tracingCfg.Compression == config.GzipCompression { @@ -219,12 +227,6 @@ func getClient(tracingCfg config.TracingConfig) (otlptrace.Client, error) { opts = append(opts, otlptracehttp.WithTimeout(time.Duration(tracingCfg.Timeout))) } - tlsConf, err := config_util.NewTLSConfig(&tracingCfg.TLSConfig) - if err != nil { - return nil, err - } - opts = append(opts, otlptracehttp.WithTLSClientConfig(tlsConf)) - client = otlptracehttp.NewClient(opts...) }