From fa16dc301af3626f58f267cfea2f2ca497875715 Mon Sep 17 00:00:00 2001 From: Carrie Edwards Date: Tue, 19 Aug 2025 13:14:54 -0700 Subject: [PATCH] Use aggregation temporality constant in function calls Signed-off-by: Carrie Edwards --- storage/remote/otlptranslator/prometheusremotewrite/helper.go | 4 ++-- .../otlptranslator/prometheusremotewrite/helper_test.go | 2 +- .../prometheusremotewrite/number_data_points.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/storage/remote/otlptranslator/prometheusremotewrite/helper.go b/storage/remote/otlptranslator/prometheusremotewrite/helper.go index 3c0c920aec..49ab973b75 100644 --- a/storage/remote/otlptranslator/prometheusremotewrite/helper.go +++ b/storage/remote/otlptranslator/prometheusremotewrite/helper.go @@ -518,7 +518,7 @@ func (c *PrometheusConverter) addSummaryDataPoints(ctx context.Context, dataPoin pt := dataPoints.At(x) timestamp := convertTimeStamp(pt.Timestamp()) - baseLabels, err := createAttributes(resource, pt.Attributes(), scope, settings, nil, false, metadata, 0) + baseLabels, err := createAttributes(resource, pt.Attributes(), scope, settings, nil, false, metadata, pmetric.AggregationTemporalityUnspecified) if err != nil { return err } @@ -666,7 +666,7 @@ func addResourceTargetInfo(resource pcommon.Resource, settings Settings, earlies // Do not pass identifying attributes as ignoreAttrs below. identifyingAttrs = nil } - labels, err := createAttributes(resource, attributes, scope{}, settings, identifyingAttrs, false, prompb.MetricMetadata{}, 0, model.MetricNameLabel, name) + labels, err := createAttributes(resource, attributes, scope{}, settings, identifyingAttrs, false, prompb.MetricMetadata{}, pmetric.AggregationTemporalityUnspecified, model.MetricNameLabel, name) if err != nil { return err } diff --git a/storage/remote/otlptranslator/prometheusremotewrite/helper_test.go b/storage/remote/otlptranslator/prometheusremotewrite/helper_test.go index 3141578da4..f55a832e73 100644 --- a/storage/remote/otlptranslator/prometheusremotewrite/helper_test.go +++ b/storage/remote/otlptranslator/prometheusremotewrite/helper_test.go @@ -531,7 +531,7 @@ func TestCreateAttributes(t *testing.T) { }), PromoteScopeMetadata: tc.promoteScope, } - lbls, err := createAttributes(resource, attrs, tc.scope, settings, tc.ignoreAttrs, false, prompb.MetricMetadata{}, 0, model.MetricNameLabel, "test_metric") + lbls, err := createAttributes(resource, attrs, tc.scope, settings, tc.ignoreAttrs, false, prompb.MetricMetadata{}, pmetric.AggregationTemporalityUnspecified, model.MetricNameLabel, "test_metric") require.NoError(t, err) require.ElementsMatch(t, lbls, tc.expectedLabels) diff --git a/storage/remote/otlptranslator/prometheusremotewrite/number_data_points.go b/storage/remote/otlptranslator/prometheusremotewrite/number_data_points.go index c3d3f9a1f5..e43fe71726 100644 --- a/storage/remote/otlptranslator/prometheusremotewrite/number_data_points.go +++ b/storage/remote/otlptranslator/prometheusremotewrite/number_data_points.go @@ -45,7 +45,7 @@ func (c *PrometheusConverter) addGaugeNumberDataPoints(ctx context.Context, data nil, true, metadata, - 0, + pmetric.AggregationTemporalityUnspecified, model.MetricNameLabel, metadata.MetricFamilyName, )