Commit Graph

13 Commits

Author SHA1 Message Date
Julien
75f94903b3 Add OpenAPI 3.2 specification generation for Prometheus HTTP API (#17825)
* Add OpenAPI 3.2 specification generation for Prometheus HTTP API

This commit introduces an OpenAPI specification for the Prometheus API.
After testing multiple code-generation servers with built-in APIs, this
implementation uses an independent spec file outside of the critical path.
This spec file is tested with a framework present in this pull request.

The specification helps clients know which parameters they can use and is
served at /api/v1/openapi.yaml. The spec file will evolve with the
Prometheus API and has the same version number.

Downstream projects can tune the APIs presented in the spec file with
configuration options using the IncludePaths setting for path filtering.

In the future, there is room to generate a server from this spec file
(e.g. with interfaces), but this is out of scope for this pull request.

Architecture:
- Core OpenAPI infrastructure (openapi.go): Dynamic spec building,
  caching, and thread-safe spec generation
- Schema definitions (openapi_schemas.go): Complete type definitions
  for all API request and response types
- Path specifications (openapi_paths.go): Endpoint definitions with
  parameters, request bodies, and response schemas
- Examples (openapi_examples.go): Realistic request/response examples
- Helper functions (openapi_helpers.go): Reusable builders for common
  OpenAPI structures

Testing:
- Comprehensive test suite with golden file validation
- Test helpers package for API testing infrastructure
- OpenAPI compliance validation utilities

The golden file captures the complete specification for snapshot testing.
Update with: go test -run TestOpenAPIGolden -update-openapi-spec

REVIEWERS: The most important thing to check would be the OpenAPI golden
file (web/api/v1/testdata/openapi_golden.yaml). Test scenarios are important
as they test the actual OpenAPI spec validity.

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>

* Add OpenAPI 3.1 support with version selection

Add support for both OpenAPI 3.1 and 3.2 specifications with version
selection via openapi_version query parameter. Defaults to 3.1 for
broader compatibility

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>

* Enhance OpenAPI examples and add helper functions

- Add timestampExamples helper for consistent time formatting
- Add exampleMap helper to simplify example creation
- Improve example summaries with query details
- Add matrix result example for range vector queries

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>

* web/api: Add AtST method to test helper iterators

Implement the AtST() method required by chunkenc.Iterator interface
for FakeSeriesIterator and FakeHistogramSeriesIterator test helpers.
The method returns 0 as these test helpers don't use start timestamps

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>

* OpenAPI: Add minimum coverage test

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>

* OpenAPI: Improve examples handling

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>

---------

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
2026-01-29 13:36:13 +01:00
Ben Kochie
628bbd2682 Update linting (#15369)
* Ignore all node_modules dirs.
* Update Makefile.common golangci-lint to match CI pipeline.

Signed-off-by: SuperQ <superq@gmail.com>
2024-11-12 13:27:39 +01:00
heyitao
c7ca85388f Fix yaml file format and clear ci errors
Signed-off-by: heyitao <heyitao@uniontech.com>
2024-03-21 11:32:02 +08:00
SuperQ
1a8f06bb7a Update sync script.
* Fix the path to the golanci-lint target filename.
* Use the target filename when printing errors.
* Put the yamllint filename back to previous name.

Signed-off-by: SuperQ <superq@gmail.com>
2023-07-01 11:37:16 +02:00
Matthieu MOREL
d5b33e1419 yamllint: don’t check keys and add file extension to config file
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2023-04-08 10:26:06 +02:00
Matthieu MOREL
7063b47abb lint(yaml) : simplify ignore path for all github workflows
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2023-01-20 09:43:35 +01:00
SuperQ
a62a9e4942 Relax yamllint
Relax indentation to allow non-indented sequences. This helps with
generated yaml linke the snmp_exporter config output.

Signed-off-by: SuperQ <superq@gmail.com>
2022-05-06 09:59:59 +02:00
Levi Harrison
cc77593176 Switch golangci-lint to GitHub Actions (#9232)
* Added golangci-lint action

Signed-off-by: Levi Harrison <git@leviharrison.dev>
2021-09-10 16:30:18 +02:00
Michal Wasilewski
b4f12e4c7a avoid glob pattern for key-duplicates
Signed-off-by: Michal Wasilewski <mwasilewski@gmx.com>
2021-06-12 13:12:47 +02:00
Michal Wasilewski
4a811c2b44 ignore truthy in selected files
Signed-off-by: Michal Wasilewski <mwasilewski@gmx.com>
2021-06-12 13:12:00 +02:00
Michal Wasilewski
6f1d3e66b5 ignore duplicate key in a file that is deliberately broken
Signed-off-by: Michal Wasilewski <mwasilewski@gmx.com>
2021-06-12 12:53:35 +02:00
Michal Wasilewski
b0f08f7adb disable warning about missing document start in yamllint
Signed-off-by: Michal Wasilewski <mwasilewski@gmx.com>
2021-06-12 12:48:47 +02:00
Michal Wasilewski
cd0281e766 Adds yamllinting to Makefile.common
* adds yamllint target to Makefile.common for use by all Prometheus projects

Signed-off-by: Michal Wasilewski <mwasilewski@gmx.com>
2021-06-12 11:17:59 +02:00