beorn7
747c5ee2b1
Apply analyzer "modernize" to the whole codebase
...
See
https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize
for details.
This ran into a few issues (arguably bugs in the modernize tool),
which I will fix in the next commit, so that we have transparency what
was done automatically.
Beyond those hiccups, I believe all the changes applied are
legitimate. Even where there might be no tangible direct gain, I would
argue it's still better to use the "modern" way to avoid micro
discussions in tiny style PRs later.
Signed-off-by: beorn7 <beorn@grafana.com >
2025-08-27 14:48:41 +02:00
Arve Knudsen
e7e3ab2824
Fix linting issues found by golangci-lint v2.0.2 ( #16368 )
...
* Fix linting issues found by golangci-lint v2.0.2
---------
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2025-05-03 19:05:13 +02:00
Matthieu MOREL
5fa1146e21
chore: enable gci linter ( #16245 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-03-22 15:46:13 +00:00
Joel Beckmeyer
39f5a07236
fix TestOOOHeadChunkReader_Chunk on 32-bit
...
Signed-off-by: Joel Beckmeyer <joel@beckmeyer.us >
2024-12-16 10:45:07 -05:00
Fiona Liao
c599d37668
Always return unknown hint for first sample in non-gauge histogram chunk ( #15343 )
...
Always return unknown hint for first sample in non-gauge histogram chunk
---------
Signed-off-by: Fiona Liao <fiona.liao@grafana.com >
Co-authored-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com >
2024-11-12 15:14:06 +01:00
Bryan Boreham
541c7fd9fe
[COMMENT] Remove duplicate line
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com >
2024-11-05 11:03:40 +00:00
Carrie Edwards
14e3c05ce8
tsdb: Add support for ingestion of out-of-order native histogram samples ( #14546 )
...
Add support for ingesting OOO native histograms
* Add flag for enabling and disabling OOO native histogram ingestion
* Update OOO querying tests to include native histogram samples
* Add OOO head tests
* Add test for OOO native histogram counter reset headers
Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com >
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com >
Co-authored by: Carrie Edwards <edwrdscarrie@gmail.com >
Co-authored by: Jeanette Tan <jeanette.tan@grafana.com >
Co-authored by: György Krajcsovits <gyorgy.krajcsovits@grafana.com >
Co-authored by: Fiona Liao <fiona.liao@grafana.com >
2024-09-17 11:19:06 +02:00
György Krajcsovits
1ea3781699
Fix ToEncodedChunks minT for recoded chunks
...
Discovered while working on #14546 OOO native histograms.
Not triggered on main before #14546 as the code path is unused.
There was a bug where the min time of a chunk was adjusted even
if it was only recoded and not completely new.
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com >
2024-08-08 15:22:46 +02:00
Oleksandr Redko
fa90ca46e5
ci(lint): enable godot; append dot at the end of comments
...
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com >
2023-10-31 19:53:38 +02:00
beorn7
817a2396cb
Name float values as "floats", not as "values"
...
In the past, every sample value was a float, so it was fine to call a
variable holding such a float "value" or "sample". With native
histograms, a sample might have a histogram value. And a histogram
value is still a value. Calling a float value just "value" or "sample"
or "V" is therefore misleading. Over the last few commits, I already
renamed many variables, but this cleans up a few more places where the
changes are more invasive.
Note that we do not to attempt naming in the JSON APIs or in the
protobufs. That would be quite a disruption. However, internally, we
can call variables as we want, and we should go with the option of
avoiding misunderstandings.
Signed-off-by: beorn7 <beorn@grafana.com >
2023-04-13 19:25:24 +02:00
Signed-off-by: Jesus Vazquez
3362bf6d79
Fix merge conflicts
...
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com >
2022-10-11 22:53:37 +05:30
Jesus Vazquez
c1b669bf9b
Add out-of-order sample support to the TSDB ( #11075 )
...
* Introduce out-of-order TSDB support
This implementation is based on this design doc:
https://docs.google.com/document/d/1Kppm7qL9C-BJB1j6yb6-9ObG3AbdZnFUBYPNNWwDBYM/edit?usp=sharing
This commit adds support to accept out-of-order ("OOO") sample into the TSDB
up to a configurable time allowance. If OOO is enabled, overlapping querying
are automatically enabled.
Most of the additions have been borrowed from
https://github.com/grafana/mimir-prometheus/
Here is the list ist of the original commits cherry picked
from mimir-prometheus into this branch:
- 4b2198d7ec2836e5513f00b379c3a5ff0dc75758a632c73352c6f3d4ab335e8406a1d4abde1e0ba1e70e769889df59320886jesus.vazquez@grafana.com >
Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com >
Co-authored-by: Dieter Plaetinck <dieter@grafana.com >
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* gofumpt files
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* Add license header to missing files
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* Fix OOO tests due to existing chunk disk mapper implementation
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* Fix truncate int overflow
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* Add Sync method to the WAL and update tests
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* remove useless sync
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* Update minOOOTime after truncating Head
* Update minOOOTime after truncating Head
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
* Fix lint
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
* Add a unit test
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* Load OutOfOrderTimeWindow only once per appender
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* Fix OOO Head LabelValues and PostingsForMatchers
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* Fix replay of OOO mmap chunks
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
* Remove unnecessary err check
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* Prevent panic with ApplyConfig
Signed-off-by: Ganesh Vernekar 15064823+codesome@users.noreply.github.com
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* Run OOO compaction after restart if there is OOO data from WBL
Signed-off-by: Ganesh Vernekar 15064823+codesome@users.noreply.github.com
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* Apply Bartek's suggestions
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com >
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* Refactor OOO compaction
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
* Address comments and TODOs
- Added a comment explaining why we need the allow overlapping
compaction toggle
- Clarified TSDBConfig OutOfOrderTimeWindow doc
- Added an owner to all the TODOs in the code
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* Run go format
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* Fix remaining review comments
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
* Fix tests
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
* Change wbl reference when truncating ooo in TestHeadMinOOOTimeUpdate
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
* Fix TestWBLAndMmapReplay test failure on windows
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
* Address most of the feedback
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
* Refactor the block meta for out of order
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
* Fix windows error
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
* Fix review comments
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com >
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
Signed-off-by: Ganesh Vernekar 15064823+codesome@users.noreply.github.com
Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com >
Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com >
Co-authored-by: Dieter Plaetinck <dieter@grafana.com >
Co-authored-by: Oleg Zaytsev <mail@olegzaytsev.com >
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com >
2022-09-20 22:35:50 +05:30
