Julien Pivotto
93e9c010f3
Add more Go leak tests ( #7652 )
...
* Implement go leak test for promql
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu >
* Implement go leak test for Consul SD
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu >
* Implement go leak test in discovery manager
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu >
2020-07-24 10:10:20 +01:00
Guangwen Feng
f50786bcd1
Add unit test case to improve test coverage for quote.go ( #7482 )
...
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com >
2020-06-30 10:33:02 +02:00
Hongcai Ren
c7e82274c6
replace github.com/prometheus/prometheus/testutil/promlint by github.com/prometheus/client_golang/prometheus/testutil/promlint from our codebase ( #7209 )
...
Signed-off-by: RainbowMango <renhongcai@huawei.com >
2020-05-07 11:34:39 +01:00
Ben Ye
1e4e37144d
Fixed wrongly handled not ready TSDB on web and API. ( #7182 )
...
* fix federate endpoint panic
Signed-off-by: yeya24 <yb532204897@gmail.com >
* Fixed all cases of not ready TSDB being wrongly handled.
* Fixed issue for federation.
* Ensured this will never happen again thanks to interfaces
* Fixes same issue for stats.
* Added tests for readiness.
* Fixed bug in stats. It was:
status.MaxTime = db.Head().MaxTime()
status.MinTime = db.Head().MaxTime()
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com >
* Addressed Brian's comments.
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com >
* Addressed Brian's comments.
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com >
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com >
2020-04-29 17:16:14 +01:00
ZouYu
2b7437d60e
Fix some warnings: 'redundant type from array, slice, or map composite literal' ( #7109 )
...
Signed-off-by: ZouYu <zouy.fnst@cn.fujitsu.com >
2020-04-15 11:17:41 +01:00
Bartlomiej Plotka
104a1313d4
testutil: Enriched Equals with diff on error. ( #7053 )
...
## Example:
```
exp: []chunks.Meta{chunks.Meta{Ref:0x0, Chunk:(*chunkenc.XORChunk)(0xc00000e160), MinTime:1, MaxTime:2}, chunks.Meta{Ref:0x0, Chunk:(*chunkenc.XORChunk)(0xc00000e180), MinTime:3, MaxTime:3}, chunks.Meta{Ref:0x0, Chunk:(*chunkenc.XORChunk)(0xc00000e1a0), MinTime:5, MaxTime:5}, chunks.Meta{Ref:0x0, Chunk:(*chunkenc.XORChunk)(0xc00000e1c0), MinTime:24, MaxTime:6}}
got: []chunks.Meta{chunks.Meta{Ref:0x0, Chunk:(*chunkenc.XORChunk)(0xc00000e280), MinTime:1, MaxTime:2}, chunks.Meta{Ref:0x0, Chunk:(*chunkenc.XORChunk)(0xc00000e2a0), MinTime:3, MaxTime:3}, chunks.Meta{Ref:0x0, Chunk:(*chunkenc.XORChunk)(0xc00000e220), MinTime:5, MaxTime:5}, chunks.Meta{Ref:0x0, Chunk:(*chunkenc.XORChunk)(0xc00000e240), MinTime:6, MaxTime:6}}
```
Now:
```
exp: []chunks.Meta{chunks.Meta{Ref:0x0, Chunk:(*chunkenc.XORChunk)(0xc00000e740), MinTime:1, MaxTime:2}, chunks.Meta{Ref:0x0, Chunk:(*chunkenc.XORChunk)(0xc00000e760), MinTime:3, MaxTime:3}, chunks.Meta{Ref:0x0, Chunk:(*chunkenc.XORChunk)(0xc00000e780), MinTime:5, MaxTime:5}, chunks.Meta{Ref:0x0, Chunk:(*chunkenc.XORChunk)(0xc00000e7a0), MinTime:24, MaxTime:6}}
got: []chunks.Meta{chunks.Meta{Ref:0x0, Chunk:(*chunkenc.XORChunk)(0xc00000e800), MinTime:1, MaxTime:2}, chunks.Meta{Ref:0x0, Chunk:(*chunkenc.XORChunk)(0xc00000e820), MinTime:3, MaxTime:3}, chunks.Meta{Ref:0x0, Chunk:(*chunkenc.XORChunk)(0xc00000e860), MinTime:5, MaxTime:5}, chunks.Meta{Ref:0x0, Chunk:(*chunkenc.XORChunk)(0xc00000e880), MinTime:6, MaxTime:6}}
Diff:
--- Expected
+++ Actual
@@ -50,3 +50,3 @@
}),
- MinTime: (int64) 24,
+ MinTime: (int64) 6,
MaxTime: (int64) 6
```
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com >
2020-03-26 11:48:23 +02:00
Björn Rabenstein
bc703b6456
Use struct{} as underlying type for context keys ( #6965 )
...
This is an alternative to #6963 .
Signed-off-by: beorn7 <beorn@grafana.com >
2020-03-11 15:05:35 +01:00
Peter Štibraný
a7d3a456d6
Updated code based on Juliens comments (via Slack).
...
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com >
2020-02-19 11:57:20 +01:00
Peter Štibraný
fe3fe5740e
Updated comment.
...
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com >
2020-02-18 21:50:47 +01:00
Peter Štibraný
baa6f60384
Changed var name.
...
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com >
2020-02-18 16:24:09 +01:00
Peter Štibraný
318cd413fc
Don't return error in ContextFromRequest function.
...
Previously it could return error if RemoteAddr didn't
have correct format, but since this field has no specified
format, that was little too strict.
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com >
2020-02-18 15:58:14 +01:00
Bartlomiej Plotka
cfba92a133
Addressed comments.
...
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com >
2020-02-17 18:03:57 +00:00
Bartlomiej Plotka
fb79f515fc
Fixed second bug.
...
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com >
2020-02-17 18:03:57 +00:00
Bartlomiej Plotka
aadffd1360
Finally found a fix for the bug I was chasing for 2h...
...
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com >
2020-02-17 18:03:57 +00:00
Bartlomiej Plotka
34426766d8
Unify Iterator interfaces. All point to storage now.
...
This is part of https://github.com/prometheus/prometheus/pull/5882 that can be done to simplify things.
All todos I added will be fixed in follow up PRs.
* querier.Querier, querier.Appender, querier.SeriesSet, and querier.Series interfaces merged
with storage interface.go. All imports that.
* querier.SeriesIterator replaced by chunkenc.Iterator
* Added chunkenc.Iterator.Seek method and tests for xor implementation (?)
* Since we properly handle SelectParams for Select methods I adjusted min max
based on that. This should help in terms of performance for queries with functions like offset.
* added Seek to deletedIterator and test.
* storage/tsdb was removed as it was only a unnecessary glue with incompatible structs.
No logic was changed, only different source of abstractions, so no need for benchmarks.
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com >
2020-02-17 18:03:54 +00:00
Julien Pivotto
5f27ac3583
Refactor query log fields ( #6694 )
...
* Refactor query log fields
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu >
2020-01-27 09:53:10 +00:00
Julien Pivotto
2b2eb79e8b
Add windows tests for query logger ( #6653 )
...
* Add windows tests
* Do not rely on time.Time in timer
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu >
2020-01-20 13:17:11 +00:00
Julien Pivotto
e7f7b6a06f
Query Log: Add source IP from console queries ( #6593 )
...
* Query Log: Add source IP from console queries
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu >
2020-01-10 12:56:36 +00:00
Josh Soref
91d76c8023
Spelling ( #6517 )
...
* spelling: alertmanager
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: attributes
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: autocomplete
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: bootstrap
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: caught
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: chunkenc
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: compaction
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: corrupted
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: deletable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: expected
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: fine-grained
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: initialized
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: iteration
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: javascript
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: multiple
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: number
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: overlapping
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: possible
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: postings
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: procedure
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: programmatic
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: queuing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: querier
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: repairing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: received
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: reproducible
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: retention
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: sample
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: segements
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: semantic
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: software [LICENSE]
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: staging
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: timestamp
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: unfortunately
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: uvarint
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: subsequently
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
* spelling: ressamples
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
2020-01-02 15:54:09 +01:00
Julien Pivotto
31700a05df
Improve testutil.ErrorEqual ( #6471 )
...
Also improves TestPopulateLabels: testutil.ErrorEqual just returned a
bool without failing the test.
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu >
2019-12-17 21:11:33 +00:00
Simon Pasquier
b15dda9e07
util/promlint: simplify sorting function ( #6448 )
...
Signed-off-by: Simon Pasquier <spasquie@redhat.com >
2019-12-11 15:45:26 +01:00
RainbowMango
f9de671cdd
Fix promlint order algorithm not work issue.
...
Signed-off-by: RainbowMango <renhongcai@huawei.com >
2019-12-11 14:56:28 +08:00
Dipack P Panjabi
ce7bab04dd
Compute WAL size and use it during retention size checks ( #5886 )
...
* Compute WAL size and account for it when applying the retention settings.
Signed-off-by: Dipack P Panjabi <dpanjabi@hudson-trading.com >
2019-11-12 09:40:16 +07:00
陈谭军
0f022aa42b
fix unreasonable goimports ( #6115 )
...
Signed-off-by: tanjunchen <2799194073@qq.com >
2019-10-09 09:43:56 +01:00
Krasi Georgiev
29c190df73
remove missing substitution in the Equal test util. ( #6039 )
...
Signed-off-by: Krasi Georgiev <8903888+krasi-georgiev@users.noreply.github.com >
2019-09-19 14:21:12 +03:00
zhulongcheng
970ef41bb6
Fix exported function comments ( #6002 )
...
Signed-off-by: zhulongcheng <zhulongcheng.dev@gmail.com >
2019-09-10 14:45:09 +01:00
David Ellis
dbfd493265
More promlint rules ( #5515 )
...
* Extra promlint rules for Issue 5453
* broaden type name and camelCase checks
* Expand unit test to catch non base units
* Use only celsius as the base unit for temperature
* Remove candela and moles from the unit check
Signed-off-by: David Ellis <ellisda@gmail.com >
2019-09-05 10:48:31 -06:00
Bartek Plotka
f0863a604e
Removed extra tsdb/testutil after merge.
...
Signed-off-by: Bartek Plotka <bwplotka@gmail.com >
2019-08-14 10:12:32 +01:00
Chris Marchbanks
529ccff07b
Remove all usages of stretchr/testify
...
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com >
2019-08-08 19:49:27 -06:00
Chris Marchbanks
0685eb5395
Refactor testutil.NewStorage into a new package
...
This avoids a circular dependency between the testutil and storage
packages.
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com >
2019-08-08 19:43:04 -06:00
Ye Ji
2c715d22cf
Fix zk connection leak ( #5675 )
...
Signed-off-by: Ye Ji <ye@hioscar.com >
2019-06-21 13:21:13 +01:00
Simon Pasquier
45506841e6
*: enable all default linters ( #5504 )
...
Signed-off-by: Simon Pasquier <spasquie@redhat.com >
2019-05-03 15:11:28 +02:00
Tariq Ibrahim
8fdfa8abea
refine error handling in prometheus ( #5388 )
...
i) Uses the more idiomatic Wrap and Wrapf methods for creating nested errors.
ii) Fixes some incorrect usages of fmt.Errorf where the error messages don't have any formatting directives.
iii) Does away with the use of fmt package for errors in favour of pkg/errors
Signed-off-by: tariqibrahim <tariq181290@gmail.com >
2019-03-26 00:01:12 +01:00
Hrishikesh Barman
9c4e258651
corrected regex string check for anyorigin(*) ( #5117 )
...
Signed-off-by: Hrishikesh Barman <hrishikeshbman@gmail.com >
2019-01-21 17:17:27 +05:30
Hrishikesh Barman
a1f34bec2e
Added CORS Origin flag ( #5011 )
...
Signed-off-by: Hrishikesh Barman <hrishikeshbman@gmail.com >
2019-01-17 15:01:06 +00:00
Simon Pasquier
f678e27eb6
*: use latest release of staticcheck ( #5057 )
...
* *: use latest release of staticcheck
It also fixes a couple of things in the code flagged by the additional
checks.
Signed-off-by: Simon Pasquier <spasquie@redhat.com >
* Use official release of staticcheck
Also run 'go list' before staticcheck to avoid failures when downloading packages.
Signed-off-by: Simon Pasquier <spasquie@redhat.com >
2019-01-04 14:47:38 +01:00
Tariq Ibrahim
a188693015
Adding unit tests for the util package ( #4534 )
...
Signed-off-by: Tariq Ibrahim <tariq.ibrahim@microsoft.com >
2018-08-27 15:55:49 +01:00
Goutham Veeramachaneni
71855a22a4
Add tracing spans to promql ( #4436 )
...
* Add spans to promql
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com >
* Simplify timer and span tracking.
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com >
2018-08-16 13:11:34 +05:30
Tom Wilkie
3b5dea4e6d
Don't import testing in code which is imported from non-test code. ( #4400 )
...
It polutes the flags.
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com >
2018-07-25 13:10:09 +01:00
Brian Brazil
dd6781add2
Optimise PromQL ( #3966 )
...
* Move range logic to 'eval'
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Make aggregegate range aware
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* PromQL is statically typed, so don't eval to find the type.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Extend rangewrapper to multiple exprs
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Start making function evaluation ranged
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Make instant queries a special case of range queries
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Eliminate evalString
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Evaluate range vector functions one series at a time
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Make unary operators range aware
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Make binops range aware
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Pass time to range-aware functions.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Make simple _over_time functions range aware
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Reduce allocs when working with matrix selectors
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Add basic benchmark for range evaluation
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Reuse objects for function arguments
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Do dropmetricname and allocating output vector only once.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Add range-aware support for range vector functions with params
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Optimise holt_winters, cut cpu and allocs by ~25%
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Make rate&friends range aware
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Make more functions range aware. Document calling convention.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Make date functions range aware
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Make simple math functions range aware
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Convert more functions to be range aware
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Make more functions range aware
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Specialcase timestamp() with vector selector arg for range awareness
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Remove transition code for functions
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Remove the rest of the engine transition code
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Remove more obselete code
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Remove the last uses of the eval* functions
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Remove engine finalizers to prevent corruption
The finalizers set by matrixSelector were being called
just before the value they were retruning to the pool
was then being provided to the caller. Thus a concurrent query
could corrupt the data that the user has just been returned.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Add new benchmark suite for range functinos
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Migrate existing benchmarks to new system
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Expand promql benchmarks
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Simply test by removing unused range code
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* When testing instant queries, check range queries too.
To protect against subsequent steps in a range query being
affected by the previous steps, add a test that evaluates
an instant query that we know works again as a range query
with the tiimestamp we care about not being the first step.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Reuse ring for matrix iters. Put query results back in pool.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Reuse buffer when iterating over matrix selectors
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Unary minus should remove metric name
Cut down benchmarks for faster runs.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Reduce repetition in benchmark test cases
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Work series by series when doing normal vectorSelectors
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Optimise benchmark setup, cuts time by 60%
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Have rangeWrapper use an evalNodeHelper to cache across steps
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Use evalNodeHelper with functions
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Cache dropMetricName within a node evaluation.
This saves both the calculations and allocs done by dropMetricName
across steps.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Reuse input vectors in rangewrapper
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Reuse the point slices in the matrixes input/output by rangeWrapper
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Make benchmark setup faster using AddFast
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Simplify benchmark code.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Add caching in VectorBinop
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Use xor to have one-level resultMetric hash key
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Add more benchmarks
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Call Query.Close in apiv1
This allows point slices allocated for the response data
to be reused by later queries, saving allocations.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Optimise histogram_quantile
It's now 5-10% faster with 97% less garbage generated for 1k steps
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Make the input collection in rangeVector linear rather than quadratic
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Optimise label_replace, for 1k steps 15x fewer allocs and 3x faster
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Optimise label_join, 1.8x faster and 11x less memory for 1k steps
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Expand benchmarks, cleanup comments, simplify numSteps logic.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Address Fabian's comments
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Comments from Alin.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Address jrv's comments
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Remove dead code
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Address Simon's comments.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Rename populateIterators, pre-init some sizes
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Handle case where function has non-matrix args first
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Split rangeWrapper out to rangeEval function, improve comments
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Cleanup and make things more consistent
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Make EvalNodeHelper public
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
* Fabian's comments.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io >
2018-06-04 15:47:45 +02:00
Adam Shannon
809881d7f5
support reading basic_auth password_file for HTTP basic auth ( #4077 )
...
Issue: https://github.com/prometheus/prometheus/issues/4076
Signed-off-by: Adam Shannon <adamkshannon@gmail.com >
2018-04-25 18:19:06 +01:00
Philippe Laflamme
2aba238f31
Use common HTTPClientConfig for marathon_sd configuration ( #4009 )
...
This adds support for basic authentication which closes #3090
The support for specifying the client timeout was removed as discussed in https://github.com/prometheus/common/pull/123 . Marathon was the only sd mechanism doing this and configuring the timeout is done through `Context`.
DC/OS uses a custom `Authorization` header for authenticating. This adds 2 new configuration properties to reflect this.
Existing configuration files that use the bearer token will no longer work. More work is required to make this backwards compatible.
2018-04-05 09:08:18 +01:00
Manos Fokas
25f929b772
Yaml UnmarshalStrict implementation. ( #4033 )
...
* Updated yaml vendor package.
* remove checkOverflow duplicate in rulefmt
* remove duplicated HTTPClientConfig.Validate()
* Added yaml static check.
2018-04-04 09:07:39 +01:00
ferhat elmas
ffa673f7d8
General simplifications ( #3887 )
...
Another try as in #1516
2018-02-26 07:58:10 +00:00
pasquier-s
a9c93b8918
Remove unused flock package ( #3853 )
2018-02-16 13:48:28 +00:00
Krasi Georgiev
4d47a48422
client test comment nits.
2018-01-29 15:26:46 +00:00
Krasi Georgiev
d202718116
read bearer token on every request , + some http and scrape tests
...
read bearer token on every request
removed unuseful scrape manager startup log
new tests -TestScrapeManagerReloadNoChange( scrape pool is not reloaded
when the config hasn't changed), TestMissingBearerAuthFile ,
TestBearerAuthFileRoundTripper
2018-01-19 11:36:21 +00:00
Shubheksha Jalan
0471e64ad1
Use shared types from the common repo ( #3674 )
...
* refactor: use shared types from common repo, remove util/config
* vendor: add common/config
* fix nit
2018-01-11 16:10:25 +01:00
Shubheksha Jalan
ec94df49d4
Refactor SD configuration to remove config dependency ( #3629 )
...
* refactor: move targetGroup struct and CheckOverflow() to their own package
* refactor: move auth and security related structs to a utility package, fix import error in utility package
* refactor: Azure SD, remove SD struct from config
* refactor: DNS SD, remove SD struct from config into dns package
* refactor: ec2 SD, move SD struct from config into the ec2 package
* refactor: file SD, move SD struct from config to file discovery package
* refactor: gce, move SD struct from config to gce discovery package
* refactor: move HTTPClientConfig and URL into util/config, fix import error in httputil
* refactor: consul, move SD struct from config into consul discovery package
* refactor: marathon, move SD struct from config into marathon discovery package
* refactor: triton, move SD struct from config to triton discovery package, fix test
* refactor: zookeeper, move SD structs from config to zookeeper discovery package
* refactor: openstack, remove SD struct from config, move into openstack discovery package
* refactor: kubernetes, move SD struct from config into kubernetes discovery package
* refactor: notifier, use targetgroup package instead of config
* refactor: tests for file, marathon, triton SD - use targetgroup package instead of config.TargetGroup
* refactor: retrieval, use targetgroup package instead of config.TargetGroup
* refactor: storage, use config util package
* refactor: discovery manager, use targetgroup package instead of config.TargetGroup
* refactor: use HTTPClient and TLS config from configUtil instead of config
* refactor: tests, use targetgroup package instead of config.TargetGroup
* refactor: fix tagetgroup.Group pointers that were removed by mistake
* refactor: openstack, kubernetes: drop prefixes
* refactor: remove import aliases forced due to vscode bug
* refactor: move main SD struct out of config into discovery/config
* refactor: rename configUtil to config_util
* refactor: rename yamlUtil to yaml_config
* refactor: kubernetes, remove prefixes
* refactor: move the TargetGroup package to discovery/
* refactor: fix order of imports
2017-12-29 21:01:34 +01:00
Bryan Boreham
a8cce41882
Set MaxIdleConnsPerHost alongside MaxIdleConns ( #3592 )
...
Otherwise it defaults to 2, and Go will close extra connections as
soon as a request is finished.
See https://github.com/golang/go/issues/13801
2017-12-17 15:15:04 +00:00