From 6dd540b09c91944b263bf60046ef7edceb723e17 Mon Sep 17 00:00:00 2001 From: leo Date: Fri, 29 Aug 2025 18:21:17 +0800 Subject: [PATCH] refactor: `Models.CommitCheckPassed` is unnecessary in async mode Signed-off-by: leo --- src/Models/Commit.cs | 8 -------- src/ViewModels/WorkingCopy.cs | 18 ++++++++---------- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/src/Models/Commit.cs b/src/Models/Commit.cs index 4fb9f7d6..61438424 100644 --- a/src/Models/Commit.cs +++ b/src/Models/Commit.cs @@ -16,14 +16,6 @@ namespace SourceGit.Models ByContent, } - public enum CommitCheckPassed - { - None = 0, - DetachedHead, - Filter, - FileCount, - } - public class Commit { // As retrieved by: git mktree _visibleStaged.Count && checkPassed < Models.CommitCheckPassed.Filter) + if (!string.IsNullOrEmpty(_filter) && _staged.Count > _visibleStaged.Count) { var msg = App.Text("WorkingCopy.ConfirmCommitWithFilter", _staged.Count, _visibleStaged.Count, _staged.Count - _visibleStaged.Count); var sure = await App.AskConfirmAsync(msg); - if (sure) - await CommitAsync(autoStage, autoPush, Models.CommitCheckPassed.Filter); - return; + if (!sure) + return; } - if (checkPassed < Models.CommitCheckPassed.FileCount && !_useAmend) + if (!_useAmend) { if ((!autoStage && _staged.Count == 0) || (autoStage && _cached.Count == 0)) {