test: align channel fixtures with open dm policy

2026-04-30 22:12:32 +08:00 · 2026-04-29 07:07:59 +01:00
parent d28500ffd6
commit 7d74c1f4b9
12 changed files with 29 additions and 22 deletions
--- a/extensions/bluebubbles/src/monitor.test.ts
+++ b/extensions/bluebubbles/src/monitor.test.ts
@@ -408,11 +408,11 @@ describe("BlueBubbles webhook monitor", () => {
      expect(sendMessageBlueBubbles).not.toHaveBeenCalled();
    });

-    it("allows all DMs when dmPolicy=open", async () => {
+    it("allows wildcard DMs when dmPolicy=open", async () => {
      setupWebhookTarget({
        account: createMockAccount({
          dmPolicy: "open",
-          allowFrom: [],
+          allowFrom: ["*"],
        }),
      });

@@ -483,6 +483,7 @@ describe("BlueBubbles webhook monitor", () => {
        account: createMockAccount({
          groupPolicy: "allowlist",
          dmPolicy: "open",
+          allowFrom: [],
        }),
      });

@@ -1876,7 +1877,7 @@ describe("BlueBubbles webhook monitor", () => {
      expect(mockDispatchReplyWithBufferedBlockDispatcher).not.toHaveBeenCalled();
    });

-    it("does not auto-authorize DM control commands in open mode without allowlists", async () => {
+    it("drops DM control commands in open mode without allowlists", async () => {
      mockHasControlCommand.mockReturnValue(true);

      setupWebhookTarget({
@@ -1894,12 +1895,7 @@ describe("BlueBubbles webhook monitor", () => {

      await dispatchWebhookPayload(payload);

-      expect(mockDispatchReplyWithBufferedBlockDispatcher).toHaveBeenCalled();
-      const latestDispatch =
-        mockDispatchReplyWithBufferedBlockDispatcher.mock.calls[
-          mockDispatchReplyWithBufferedBlockDispatcher.mock.calls.length - 1
-        ]?.[0];
-      expect(latestDispatch?.ctx?.CommandAuthorized).toBe(false);
+      expect(mockDispatchReplyWithBufferedBlockDispatcher).not.toHaveBeenCalled();
    });
  });

--- a/extensions/bluebubbles/src/monitor.webhook.test-helpers.ts
+++ b/extensions/bluebubbles/src/monitor.webhook.test-helpers.ts
@@ -34,7 +34,7 @@ export function createMockAccount(
      password: "test-password",
      dmPolicy: "open",
      groupPolicy: "open",
-      allowFrom: [],
+      allowFrom: ["*"],
      groupAllowFrom: [],
      ...overrides,
    },
--- a/extensions/discord/src/monitor.test.ts
+++ b/extensions/discord/src/monitor.test.ts
@@ -1008,7 +1008,7 @@ function makeReactionListenerParams(overrides?: {
    groupDmEnabled: overrides?.groupDmEnabled ?? true,
    groupDmChannels: overrides?.groupDmChannels ?? [],
    dmPolicy: overrides?.dmPolicy ?? "open",
-    allowFrom: overrides?.allowFrom ?? [],
+    allowFrom: overrides?.allowFrom ?? ["*"],
    groupPolicy: overrides?.groupPolicy ?? "open",
    allowNameMatching: overrides?.allowNameMatching ?? false,
    guildEntries: overrides?.guildEntries,
--- a/extensions/discord/src/monitor/acp-bind-here.integration.test.ts
+++ b/extensions/discord/src/monitor/acp-bind-here.integration.test.ts
@@ -200,6 +200,7 @@ describe("Discord ACP bind here end-to-end flow", () => {
        client: createDmClient("dm-1"),
        botUserId: "bot-1",
      }),
+      allowFrom: ["*"],
    });

    expect(preflight).not.toBeNull();
--- a/extensions/discord/src/monitor/native-command.plugin-dispatch.test.ts
+++ b/extensions/discord/src/monitor/native-command.plugin-dispatch.test.ts
@@ -35,7 +35,7 @@ function createConfig(): OpenClawConfig {
  return {
    channels: {
      discord: {
-        dm: { enabled: true, policy: "open" },
+        dm: { enabled: true, policy: "open", allowFrom: ["*"] },
      },
    },
  } as OpenClawConfig;
@@ -80,7 +80,7 @@ function createConfiguredAcpCase(params: {
          ? {
              channels: {
                discord: {
-                  dm: { enabled: true, policy: "open" },
+                  dm: { enabled: true, policy: "open", allowFrom: ["*"] },
                },
              },
            }
--- a/extensions/discord/src/monitor/native-command.status-direct.test.ts
+++ b/extensions/discord/src/monitor/native-command.status-direct.test.ts
@@ -40,7 +40,7 @@ function createConfig(params?: { requireMention?: boolean }): OpenClawConfig {
    },
    channels: {
      discord: {
-        dm: { enabled: true, policy: "open" },
+        dm: { enabled: true, policy: "open", allowFrom: ["*"] },
        guilds: {
          guild1: {
            requireMention: true,
--- a/extensions/feishu/src/monitor.bot-menu.lifecycle.test-support.ts
+++ b/extensions/feishu/src/monitor.bot-menu.lifecycle.test-support.ts
@@ -41,9 +41,11 @@ const lifecycleConfig = createFeishuLifecycleConfig({
  appSecret: "secret_test",
  channelConfig: {
    dmPolicy: "open",
+    allowFrom: ["ou_user1"],
  },
  accountConfig: {
    dmPolicy: "open",
+    allowFrom: ["ou_user1"],
  },
 });

@@ -53,6 +55,7 @@ const lifecycleAccount = createResolvedFeishuLifecycleAccount({
  appSecret: "secret_test",
  config: {
    dmPolicy: "open",
+    allowFrom: ["ou_user1"],
  },
 });

--- a/extensions/feishu/src/monitor.card-action.lifecycle.test-support.ts
+++ b/extensions/feishu/src/monitor.card-action.lifecycle.test-support.ts
@@ -43,9 +43,11 @@ const lifecycleConfig = createFeishuLifecycleConfig({
  appSecret: "secret_test",
  channelConfig: {
    dmPolicy: "open",
+    allowFrom: ["ou_user1"],
  },
  accountConfig: {
    dmPolicy: "open",
+    allowFrom: ["ou_user1"],
  },
 });

@@ -55,6 +57,7 @@ const lifecycleAccount = createResolvedFeishuLifecycleAccount({
  appSecret: "secret_test",
  config: {
    dmPolicy: "open",
+    allowFrom: ["ou_user1"],
  },
 });

--- a/extensions/imessage/src/monitor/self-chat-dedupe.test.ts
+++ b/extensions/imessage/src/monitor/self-chat-dedupe.test.ts
@@ -44,7 +44,6 @@ function createParams(
    cfg,
    accountId: "default",
    opts: undefined,
-    allowFrom: [],
    groupAllowFrom: [],
    groupPolicy: "open",
    dmPolicy: "open",
@@ -55,6 +54,7 @@ function createParams(
    selfChatCache: undefined,
    logVerbose: undefined,
    ...restOverrides,
+    allowFrom: restOverrides.allowFrom ?? ["*"],
    message,
    messageText,
    bodyText,
--- a/extensions/signal/src/monitor/event-handler.inbound-context.test.ts
+++ b/extensions/signal/src/monitor/event-handler.inbound-context.test.ts
@@ -168,7 +168,7 @@ describe("signal createSignalEventHandler inbound context", () => {
    );
  });

-  it("does not auto-authorize DM commands in open mode without allowlists", async () => {
+  it("drops DM commands in open mode without allowlists", async () => {
    const handler = createSignalEventHandler(
      createBaseSignalEventHandlerDeps({
        cfg: {
@@ -193,8 +193,8 @@ describe("signal createSignalEventHandler inbound context", () => {
      }),
    );

-    expect(capture.ctx).toBeTruthy();
-    expect(capture.ctx?.CommandAuthorized).toBe(false);
+    expect(capture.ctx).toBeUndefined();
+    expect(dispatchInboundMessageMock).not.toHaveBeenCalled();
  });

  it("drops quote-only group context from non-allowlisted quoted senders in allowlist mode", async () => {
--- a/extensions/telegram/src/bot-message-context.test-harness.ts
+++ b/extensions/telegram/src/bot-message-context.test-harness.ts
@@ -3,7 +3,7 @@ import { finalizeTelegramInboundContextForTest } from "./bot-message-context.ses

 export const baseTelegramMessageContextConfig = {
  agents: { defaults: { model: "anthropic/claude-opus-4-5", workspace: "/tmp/openclaw" } },
-  channels: { telegram: {} },
+  channels: { telegram: { dmPolicy: "open", allowFrom: ["*"] } },
  messages: { groupChat: { mentionPatterns: [] } },
 } as never;

@@ -80,7 +80,7 @@ export async function buildTelegramMessageContextForTest(
    historyLimit: 0,
    groupHistories: new Map(),
    dmPolicy: "open",
-    allowFrom: [],
+    allowFrom: ["*"],
    groupAllowFrom: [],
    ackReactionScope: "off",
    logger: { info: vi.fn() },
--- a/extensions/zalouser/src/monitor.group-gating.test.ts
+++ b/extensions/zalouser/src/monitor.group-gating.test.ts
@@ -21,6 +21,8 @@ function createAccount(): ResolvedZalouserAccount {
    profile: "default",
    authenticated: true,
    config: {
+      dmPolicy: "open",
+      allowFrom: ["*"],
      groupPolicy: "open",
      groups: {
        "*": { requireMention: true },
@@ -34,6 +36,8 @@ function createConfig(): OpenClawConfig {
    channels: {
      zalouser: {
        enabled: true,
+        dmPolicy: "open",
+        allowFrom: ["*"],
        groups: {
          "*": { requireMention: true },
        },
@@ -619,7 +623,7 @@ describe("zalouser monitor group mention gating", () => {
    expect(callArg?.ctx?.SessionKey).toBe("agent:main:zalouser:group:321");
  });

-  it("reads pairing store for open DM control commands", async () => {
+  it("skips pairing store read for open DM control commands", async () => {
    const { readAllowFromStore } = installRuntime({
      commandAuthorized: false,
    });
@@ -637,7 +641,7 @@ describe("zalouser monitor group mention gating", () => {
      runtime: createRuntimeEnv(),
    });

-    expect(readAllowFromStore).toHaveBeenCalledTimes(1);
+    expect(readAllowFromStore).not.toHaveBeenCalled();
  });

  it("skips pairing store read for open DM non-command messages", async () => {