Fiona Liao
207d8a4c38
Update index.md
...
Signed-off-by: Fiona Liao <fiona.liao@grafana.com >
2025-02-13 14:19:19 +00:00
Björn Rabenstein
906f6a33b6
Merge pull request #15987 from prometheus/beorn7/histogram
...
promql: Fix counter reset detection in subqueries with histograms
2025-02-11 20:41:19 +01:00
Björn Rabenstein
13c05a385c
Merge pull request #16007 from mmorel-35/revive/early-return
...
chore: enable early-return from revive
2025-02-11 20:31:34 +01:00
beorn7
14bb63c467
promql: Fix counter reset detection in subqueries with histograms
...
Signed-off-by: beorn7 <beorn@grafana.com >
2025-02-11 20:04:10 +01:00
beorn7
6518941d73
promql: Expose problem with histogram counter resets in subquery
...
Signed-off-by: beorn7 <beorn@grafana.com >
2025-02-11 20:04:10 +01:00
Bartlomiej Plotka
8baad1a73e
Bump promci to latest to avoid deprecated actions/cache CI issue. ( #16013 )
...
Current main is broken due to:
```
Error: This request has been automatically failed because it uses a deprecated version of `actions/cache: 0c45773b623bea8c8e75f6c82b208c3cf94ea4f9`. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
```
This is odd given `actions/cache: 0c45773b623bea8c8e75f6c82b208c3cf94ea4f9` has a comment of v4.0.2 (so not v1 and v2), trying 4.1.0.
https://github.com/prometheus/prometheus/actions/runs/13267052807/job/37037025130?pr=16011
Signed-off-by: bwplotka <bwplotka@gmail.com >
2025-02-11 18:09:21 +00:00
Ayoub Mrini
de6add2c7d
Merge pull request #14228 from Codelax/sd-scaleway-routed-ips
...
feat(scaleway-sd): add labels for multiple public IPs
2025-02-11 17:21:29 +01:00
jub0bs
329ec6831a
util/httputil: reduce heap allocations in newCompressedResponseWriter ( #16001 )
...
* util/httputil: Benchmark newCompressedResponseWriter
This benchmark illustrates that newCompressedResponseWriter incurs a
prohibitive amount of heap allocations when handling a request containing a
malicious Accept-Encoding header.¬
Signed-off-by: jub0bs <jcretel-infosec+github@protonmail.com >
* util/httputil: Improve newCompressedResponseWriter
This change dramatically reduces the heap allocations (in bytes)
incurred when handling a request containing a malicious Accept-Encoding header.
Below are some benchmark results; for conciseness, I've omitted the name of the
benchmark function (BenchmarkNewCompressionHandler_MaliciousAcceptEncoding):
```
goos: darwin
goarch: amd64
pkg: github.com/prometheus/prometheus/util/httputil
cpu: Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
│ old │ new │
│ sec/op │ sec/op vs base │
18.60m ± 2% 13.54m ± 3% -27.17% (p=0.000 n=10)
│ old │ new │
│ B/op │ B/op vs base │
16785442.50 ± 0% 32.00 ± 0% -100.00% (p=0.000 n=10)
│ old │ new │
│ allocs/op │ allocs/op vs base │
2.000 ± 0% 1.000 ± 0% -50.00% (p=0.000 n=10)
```
Signed-off-by: jub0bs <jcretel-infosec+github@protonmail.com >
---------
Signed-off-by: jub0bs <jcretel-infosec+github@protonmail.com >
2025-02-11 14:14:55 +01:00
Matthieu MOREL
b472ce7010
chore: enable early-return from revive
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-02-10 22:08:43 +01:00
Bryan Boreham
b74cebf6bf
Merge pull request #12920 from prymitive/compactLock
...
Fix locks in db.reloadBlocks()
2025-02-10 17:35:09 +00:00
Bartlomiej Plotka
8cd9069cf1
textparse: Refactor benchmark testdata for all types. ( #15998 )
...
Also:
* split benchmark functions to make sure no one compares across parsers.
* testdata file have meaningful names reflecting the type representation
* promtestdata.txt now has all types, taken directly from long running Prometheus (https://demo.do.prometheus.io/ )
Needed for https://github.com/prometheus/prometheus/pull/15731
Signed-off-by: bwplotka <bwplotka@gmail.com >
2025-02-10 12:26:18 +00:00
Julius Volz
402fa38e84
Improve tick rendering ( #15999 )
...
Move to 24h-based time formatting and unambiguous date formats. Also add
more details to the default formatting of each tick instead of only showing
e.g. minutes/seconds at rollover ticks for the shorter breakpoints.
Fixes https://github.com/prometheus/prometheus/issues/15913
Signed-off-by: Julius Volz <julius.volz@gmail.com >
2025-02-10 13:19:56 +01:00
Matthias Loibl
b0d82e4c24
Merge pull request #15826 from obliadp/fix/mixin-clusterLabel
...
mixin: replace use of 'cluster' with clusterLabel variable in dashboards
2025-02-10 11:29:26 +00:00
Björn Rabenstein
585a219622
Merge pull request #15845 from prometheus/beorn7/doc
...
docs: Update PromQL documentation to match the native histogram spec
2025-02-08 00:24:29 +01:00
beorn7
993d4e71c9
docs: Update PromQL documentation to match the native histogram spec
...
This is also meant to document the actual implementation, but
see #13934 for the current state.
This also improves and streamlines some parts of the documentation
that are not strictly native histogram related, but are colocated with
them. In particular, the section about aggregation operators got
restructured quite a bit, including the removal of a quite verbose
example for `limit_ratio` (which was just too long an this location
and also a bit questionabl in its usefulness).
Signed-off-by: beorn7 <beorn@grafana.com >
2025-02-07 22:47:59 +01:00
dependabot[bot]
78055a5932
chore(deps): bump github.com/digitalocean/godo from 1.132.0 to 1.136.0 ( #15920 )
...
Bumps [github.com/digitalocean/godo](https://github.com/digitalocean/godo ) from 1.132.0 to 1.136.0.
- [Release notes](https://github.com/digitalocean/godo/releases )
- [Changelog](https://github.com/digitalocean/godo/blob/main/CHANGELOG.md )
- [Commits](https://github.com/digitalocean/godo/compare/v1.132.0...v1.136.0 )
---
updated-dependencies:
- dependency-name: github.com/digitalocean/godo
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-07 21:40:03 +01:00
dependabot[bot]
9c5fd0b9fb
chore(deps): bump actions/setup-go from 5.2.0 to 5.3.0 ( #15957 )
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](3041bf56c9...f111f3307dsupport@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-07 19:10:17 +00:00
dependabot[bot]
994767eb94
chore(deps): bump google.golang.org/api from 0.218.0 to 0.219.0 ( #15919 )
...
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client ) from 0.218.0 to 0.219.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases )
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md )
- [Commits](https://github.com/googleapis/google-api-go-client/compare/v0.218.0...v0.219.0 )
---
updated-dependencies:
- dependency-name: google.golang.org/api
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-07 19:17:37 +01:00
dependabot[bot]
249c67dd19
chore(deps): bump github.com/linode/linodego from 1.46.0 to 1.47.0 ( #15918 )
...
Bumps [github.com/linode/linodego](https://github.com/linode/linodego ) from 1.46.0 to 1.47.0.
- [Release notes](https://github.com/linode/linodego/releases )
- [Commits](https://github.com/linode/linodego/compare/v1.46.0...v1.47.0 )
---
updated-dependencies:
- dependency-name: github.com/linode/linodego
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-07 19:17:30 +01:00
dependabot[bot]
37092fdad7
chore(deps): bump github.com/prometheus/sigv4 from 0.1.1 to 0.1.2 ( #15922 )
...
Bumps [github.com/prometheus/sigv4](https://github.com/prometheus/sigv4 ) from 0.1.1 to 0.1.2.
- [Release notes](https://github.com/prometheus/sigv4/releases )
- [Changelog](https://github.com/prometheus/sigv4/blob/main/RELEASE.md )
- [Commits](https://github.com/prometheus/sigv4/compare/v0.1.1...v0.1.2 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/sigv4
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-07 19:16:54 +01:00
dependabot[bot]
0e69b20098
chore(deps): bump github.com/hetznercloud/hcloud-go/v2 ( #15921 )
...
Bumps [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go ) from 2.18.0 to 2.19.0.
- [Release notes](https://github.com/hetznercloud/hcloud-go/releases )
- [Changelog](https://github.com/hetznercloud/hcloud-go/blob/main/CHANGELOG.md )
- [Commits](https://github.com/hetznercloud/hcloud-go/compare/v2.18.0...v2.19.0 )
---
updated-dependencies:
- dependency-name: github.com/hetznercloud/hcloud-go/v2
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-07 19:16:49 +01:00
dependabot[bot]
0ef0d92fdb
chore(deps): bump github.com/docker/docker ( #15923 )
...
Bumps [github.com/docker/docker](https://github.com/docker/docker ) from 27.4.1+incompatible to 27.5.1+incompatible.
- [Release notes](https://github.com/docker/docker/releases )
- [Commits](https://github.com/docker/docker/compare/v27.4.1...v27.5.1 )
---
updated-dependencies:
- dependency-name: github.com/docker/docker
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-07 19:16:24 +01:00
dependabot[bot]
47f3ddbb34
chore(deps): bump github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor ( #15924 )
...
Bumps [github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor](https://github.com/open-telemetry/opentelemetry-collector-contrib ) from 0.116.0 to 0.118.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-collector-contrib/releases )
- [Changelog](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CHANGELOG-API.md )
- [Commits](https://github.com/open-telemetry/opentelemetry-collector-contrib/compare/v0.116.0...v0.118.0 )
---
updated-dependencies:
- dependency-name: github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-07 19:15:52 +01:00
dependabot[bot]
1dc7ed2e92
chore(deps): bump actions/setup-go from 5.2.0 to 5.3.0 in /scripts ( #15956 )
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](3041bf56c9...f111f3307dsupport@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-07 19:14:11 +01:00
dependabot[bot]
665d605828
chore(deps): bump golangci/golangci-lint-action in /scripts ( #15955 )
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 6.1.1 to 6.2.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](971e284b60...ec5d18412csupport@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-07 19:14:06 +01:00
dependabot[bot]
6db18abe4e
chore(deps): bump golangci/golangci-lint-action from 6.1.1 to 6.2.0 ( #15958 )
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 6.1.1 to 6.2.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](971e284b60...ec5d18412csupport@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-07 19:13:23 +01:00
dependabot[bot]
bc07189662
chore(deps): bump actions/stale from 9.0.0 to 9.1.0 ( #15959 )
...
Bumps [actions/stale](https://github.com/actions/stale ) from 9.0.0 to 9.1.0.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](28ca103628...5bef64f19dsupport@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-07 19:12:51 +01:00
dependabot[bot]
92873bbfe8
chore(deps): bump github/codeql-action from 3.28.0 to 3.28.8 ( #15960 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.0 to 3.28.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](48ab28a6f5...dd746615b3support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-07 19:12:24 +01:00
dependabot[bot]
f453f43178
chore(deps): bump actions/upload-artifact from 4.5.0 to 4.6.0 ( #15961 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](6f51ac03b9...65c4c4a1ddsupport@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-07 19:12:03 +01:00
dependabot[bot]
151d7e6c28
chore(deps): bump bufbuild/buf-setup-action from 1.48.0 to 1.50.0 ( #15962 )
...
Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action ) from 1.48.0 to 1.50.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases )
- [Commits](1115d0acd3...a47c93e0b1support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-07 19:11:47 +01:00
Dimitar Dimitrov
686dcc7b0d
headIndexReader: reduce debug logging ( #15993 )
...
Around Mimir compactions we see logging in ShardedPostings do massive allocations and drive GC up to 50% of CPU.
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com >
2025-02-07 15:46:55 +00:00
Neeraj Gartia
20371118b6
[FIX] PromQL: Ignore histograms in scalar, sort and sort_desc functions ( #15964 )
...
PromQL: Ignore histograms in scalar, sort and sort_desc functions
---------
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com >
2025-02-06 16:02:03 +01:00
Björn Rabenstein
cb096a8ea8
Merge pull request #15902 from prometheus/beorn7/promql
...
promql: fix rate calculation with a counter reset after the 1st sample
2025-02-05 22:10:45 +01:00
Björn Rabenstein
fa1bd02c99
Merge pull request #15974 from jhesketh/jhesketh/utf-label-replace
...
Allow UTF-8 labels in label_replace
2025-02-05 20:49:36 +01:00
Joshua Hesketh
5a5fdea7ad
Fix duplicate output vector if delayed name removal is disabled ( #15975 )
...
Fix duplicate output vector if delayed name removal is disabled
This error is emitted in cleanupMetricLabels, but is skipped if
enableDelayedNameRemoval is false.
This makes it consistent with label_replace
Signed-off-by: Joshua Hesketh <josh@nitrotech.org >
---------
Signed-off-by: Joshua Hesketh <josh@nitrotech.org >
Signed-off-by: Björn Rabenstein <github@rabenste.in >
Co-authored-by: Björn Rabenstein <github@rabenste.in >
2025-02-05 16:40:23 +01:00
Björn Rabenstein
c9320da61e
Merge pull request #15970 from charleskorn/charleskorn/zero-length-range
...
promql: fix behaviour of range vector selectors with 0 length range
2025-02-05 16:26:13 +01:00
Joshua Hesketh
5be3197701
Update the test to invalid utf-8
...
"invalid-label-name" is valid in utf-8 mode
Signed-off-by: Joshua Hesketh <josh@nitrotech.org >
2025-02-05 23:08:24 +11:00
Joshua Hesketh
e4037b3ec3
Allow UTF-8 labels in label_replace
...
This makes it consistent with label_join.
Signed-off-by: Joshua Hesketh <josh@nitrotech.org >
2025-02-05 22:24:13 +11:00
Charles Korn
69ce0c24db
Fix issue
...
Signed-off-by: Charles Korn <charles.korn@grafana.com >
2025-02-05 11:48:47 +11:00
Charles Korn
2fc6ba1c94
Expand TestInstantQueryWithRangeVectorSelector to include histograms
...
Signed-off-by: Charles Korn <charles.korn@grafana.com >
2025-02-05 11:45:16 +11:00
Charles Korn
026d0198d5
Add unit tests
...
Signed-off-by: Charles Korn <charles.korn@grafana.com >
2025-02-05 11:40:54 +11:00
asymmetric
96f31e370b
doc: clarify rate values are averaged ( #14045 )
...
* doc: clarify `rate` values are averaged
Signed-off-by: asymmetric <101816+asymmetric@users.noreply.github.com >
Co-authored-by: Björn Rabenstein <github@rabenste.in >
2025-02-04 11:34:59 +00:00
dependabot[bot]
23b8dfb357
chore(deps): bump github.com/prometheus/common ( #15963 )
...
Bumps [github.com/prometheus/common](https://github.com/prometheus/common ) from 0.61.0 to 0.62.0.
- [Release notes](https://github.com/prometheus/common/releases )
- [Changelog](https://github.com/prometheus/common/blob/main/RELEASE.md )
- [Commits](https://github.com/prometheus/common/compare/v0.61.0...v0.62.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/common
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-04 07:21:32 +00:00
Bartlomiej Plotka
7427753922
scrape: Add realistic data case for scrape loop append bench. ( #15966 )
...
* scrape: Add realistic data case for scrape loop append bench.
Signed-off-by: bwplotka <bwplotka@gmail.com >
* Update scrape/scrape_test.go
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com >
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com >
---------
Signed-off-by: bwplotka <bwplotka@gmail.com >
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com >
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com >
2025-02-03 14:46:39 +00:00
Neeraj Gartia
8be416a67c
[FIX] PromQL: Updates annotation for bin op between incompatible histograms ( #15895 )
...
PromQL: Updates annotation for bin op between incompatible histograms
---------
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com >
2025-02-01 22:57:29 +01:00
Neeraj Gartia
130cd024e0
[FEATURE] PromQL: Implements idelta and irate with histograms ( #15853 )
...
Add native histogram support to idelta and irate functions
---------
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com >
2025-01-31 23:11:03 +01:00
SuryaPrakash
cb3b17a14c
fix: os.MkdirTemp with t.TempDir ( #15860 )
...
Signed-off-by: Surya Prakash <surya0prakash@proton.me >
2025-01-31 14:32:20 +00:00
Björn Rabenstein
3389cdf957
Merge pull request #15903 from prometheus/beorn7/promql2
...
promqltest: Small formatting improvement for native histograms
2025-01-29 18:43:38 +01:00
beorn7
9f6c1d9cd3
promqltest: Small formatting improvement for native histograms
...
A `HistogramTestExpression` was missed in one case, which made the
formatting weird in case a histogram got unexpectedly returned.
Signed-off-by: beorn7 <beorn@grafana.com >
2025-01-29 17:26:08 +01:00
beorn7
2581c7d057
promql: fix rate calculation with a counter reset after the 1st histogram
...
If a rate (or increase) is calculated on native histograms, and there
is a counter reset between the 1st and 2nd histogram, we never have to
touch the 1st histogram, so it doesn't even matter if it has an
incompatible bucket layout. So we should not error out in that case.
This simply nulls out the 1st histogram in that case.
Signed-off-by: beorn7 <beorn@grafana.com >
2025-01-29 15:42:47 +01:00
