github-mirrors/sourcegit
1
0
Fork 0
mirror of https://fastgit.cc/github.com/sourcegit-scm/sourcegit synced 2026-04-30 13:51:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Models.CommitCheckPassed is unnecessary in async mode

Browse Source 
Signed-off-by: leo <longshuang@msn.cn>
This commit is contained in:
leo
2025-08-29 18:21:17 +08:00
parent 6f24d660c6
commit 6dd540b09c
2 changed files with 8 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Models/Commit.cs
View File

@@ -16,14 +16,6 @@ namespace SourceGit.Models
ByContent,
}
public enum CommitCheckPassed
{
None = 0,
DetachedHead,
Filter,
FileCount,
}
public class Commit
{
// As retrieved by: git mktree </dev/null

18
src/ViewModels/WorkingCopy.cs
View File

@@ -625,7 +625,7 @@ namespace SourceGit.ViewModels
_repo.Settings.CommitMessages.Clear();
}
public async Task CommitAsync(bool autoStage, bool autoPush, Models.CommitCheckPassed checkPassed = Models.CommitCheckPassed.None)
public async Task CommitAsync(bool autoStage, bool autoPush)
{
if (string.IsNullOrWhiteSpace(_commitMessage))
return;
@@ -642,25 +642,23 @@ namespace SourceGit.ViewModels
return;
}
if (_repo.CurrentBranch is { IsDetachedHead: true } && checkPassed < Models.CommitCheckPassed.DetachedHead)
if (_repo.CurrentBranch is { IsDetachedHead: true })
{
var msg = App.Text("WorkingCopy.ConfirmCommitWithDetachedHead");
var sure = await App.AskConfirmAsync(msg);
if (sure)
await CommitAsync(autoStage, autoPush, Models.CommitCheckPassed.DetachedHead);
return;
if (!sure)
return;
}
if (!string.IsNullOrEmpty(_filter) && _staged.Count > _visibleStaged.Count && checkPassed < Models.CommitCheckPassed.Filter)
if (!string.IsNullOrEmpty(_filter) && _staged.Count > _visibleStaged.Count)
{
var msg = App.Text("WorkingCopy.ConfirmCommitWithFilter", _staged.Count, _visibleStaged.Count, _staged.Count - _visibleStaged.Count);
var sure = await App.AskConfirmAsync(msg);
if (sure)
await CommitAsync(autoStage, autoPush, Models.CommitCheckPassed.Filter);
return;
if (!sure)
return;
}
if (checkPassed < Models.CommitCheckPassed.FileCount && !_useAmend)
if (!_useAmend)
{
if ((!autoStage && _staged.Count == 0) || (autoStage && _cached.Count == 0))
{