code_style: it's not necessary to make GetLines virtual

Signed-off-by: leo <longshuang@msn.cn>
This commit is contained in:
leo
2025-12-04 11:23:47 +08:00
parent f318ecaacc
commit 73b9adea4d

View File

@@ -478,11 +478,6 @@ namespace SourceGit.Views
TextArea.TextView.LineTransformers.Add(_lineStyleTransformer);
}
public virtual List<Models.TextDiffLine> GetLines()
{
return [];
}
public virtual void UpdateSelectedChunk(double y)
{
}
@@ -745,6 +740,17 @@ namespace SourceGit.Views
SetCurrentValue(SelectedChunkProperty, chunk);
}
private List<Models.TextDiffLine> GetLines()
{
if (DataContext is ViewModels.CombinedTextDiff combined)
return combined.Data.Lines;
if (DataContext is ViewModels.TwoSideTextDiff twoSides)
return IsOld ? twoSides.Old : twoSides.New;
return [];
}
private void UpdateTextMate()
{
if (UseSyntaxHighlighting)
@@ -883,13 +889,6 @@ namespace SourceGit.Views
TextArea.LeftMargins.Add(new LineModifyTypeMargin());
}
public override List<Models.TextDiffLine> GetLines()
{
if (DataContext is ViewModels.CombinedTextDiff { Data: { } diff })
return diff.Lines;
return [];
}
public override void UpdateSelectedChunk(double y)
{
if (DataContext is not ViewModels.CombinedTextDiff { Data: { } diff } combined)
@@ -1062,13 +1061,6 @@ namespace SourceGit.Views
TextArea.LeftMargins.Add(new LineModifyTypeMargin());
}
public override List<Models.TextDiffLine> GetLines()
{
if (DataContext is ViewModels.TwoSideTextDiff diff)
return IsOld ? diff.Old : diff.New;
return [];
}
public override void UpdateSelectedChunk(double y)
{
if (DataContext is not ViewModels.TwoSideTextDiff diff)