github-mirrors/sourcegit
1
0
Fork 0
mirror of https://fastgit.cc/github.com/sourcegit-scm/sourcegit synced 2026-04-22 13:51:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: Open Terminal on Welcome Page crashed (Windows) (#1740)

Browse Source 
Trying to open the Windows Terminal on the Welcome Page crashed with a
`NullReferenceException`.  The code for Windows after the fix is similar
to the corresponding code for Linux.
This commit is contained in:
Sina Hinderks
2025-08-18 04:36:17 +02:00
committed by GitHub
parent 8a0c2f11ef
commit 79cf73e8af
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Native/Windows.cs
View File

@@ -203,19 +203,23 @@ namespace SourceGit.Native
public void OpenTerminal(string workdir)
{
if (!File.Exists(OS.ShellOrTerminal))
var home = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile);
var cwd = string.IsNullOrEmpty(workdir) ? home : workdir;
var terminal = OS.ShellOrTerminal;
if (!File.Exists(terminal))
{
App.RaiseException(workdir, "Terminal is not specified! Please confirm that the correct shell/terminal has been configured.");
return;
}
var startInfo = new ProcessStartInfo();
startInfo.WorkingDirectory = workdir;
startInfo.FileName = OS.ShellOrTerminal;
startInfo.WorkingDirectory = cwd;
startInfo.FileName = terminal;
// Directly launching `Windows Terminal` need to specify the `-d` parameter
if (OS.ShellOrTerminal.EndsWith("wt.exe", StringComparison.OrdinalIgnoreCase))
startInfo.Arguments = $"-d {workdir.Quoted()}";
if (terminal.EndsWith("wt.exe", StringComparison.OrdinalIgnoreCase))
startInfo.Arguments = $"-d {cwd.Quoted()}";
Process.Start(startInfo);
}