github-mirrors/sourcegit
1
0
Fork 0
mirror of https://fastgit.cc/github.com/sourcegit-scm/sourcegit synced 2026-04-21 05:10:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

code_style: remove DirectoryInfoExtension.GetRelativePath since it is not safe while being used out of DirectoryInfoExtension.WalkFiles

Browse Source 
Signed-off-by: leo <longshuang@msn.cn>
This commit is contained in:
leo
2026-03-05 16:02:24 +08:00
parent 30d5700f88
commit da39cb949f
3 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/App.Extensions.cs
View File

@@ -57,10 +57,5 @@ namespace SourceGit
// Ignore exceptions.
}
}
public static string GetRelativePath(this DirectoryInfo dir, string fullpath)
{
return fullpath.Substring(dir.FullName.Length).TrimStart(Path.DirectorySeparatorChar);
}
}
}

6
src/Models/ExternalTool.cs
View File

@@ -230,10 +230,14 @@ namespace SourceGit.Models
return null;
var options = new List<ExternalTool.LaunchOption>();
var prefixLen = root.FullName.Length;
root.WalkFiles(f =>
{
if (f.EndsWith(".code-workspace", StringComparison.OrdinalIgnoreCase))
options.Add(new(root.GetRelativePath(f), f.Quoted()));
{
var display = f.Substring(prefixLen).TrimStart(Path.DirectorySeparatorChar);
options.Add(new(display, f.Quoted()));
}
}, 2);
return options;
}

6
src/Native/Windows.cs
View File

@@ -234,11 +234,15 @@ namespace SourceGit.Native
return null;
var options = new List<Models.ExternalTool.LaunchOption>();
var prefixLen = root.FullName.Length;
root.WalkFiles(f =>
{
if (f.EndsWith(".sln", StringComparison.OrdinalIgnoreCase) ||
f.EndsWith(".slnx", StringComparison.OrdinalIgnoreCase))
options.Add(new(root.GetRelativePath(f), f.Quoted()));
{
var display = f.Substring(prefixLen).TrimStart(Path.DirectorySeparatorChar);
options.Add(new(display, f.Quoted()));
}
});
return options;
}